linux-kernel - Re: [PATCH] drm/vmwgfx_kms: Fix potential NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171205094713.Horde.5_tExSIcsBR4JvXtQE8cQcW@gator4166.hostgator.com>
Date:   Tue, 05 Dec 2017 09:47:13 -0600
From:   "Gustavo A. R. Silva" <garsilva@...eddedor.com>
To:     Ville Syrjälä <ville.syrjala@...ux.intel.com>
Cc:     VMware Graphics <linux-graphics-maintainer@...are.com>,
        Sinclair Yeh <syeh@...are.com>,
        Thomas Hellstrom <thellstrom@...are.com>,
        David Airlie <airlied@...ux.ie>, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm/vmwgfx_kms: Fix potential NULL pointer dereference

Hi Ville,

Quoting Ville Syrjälä <ville.syrjala@...ux.intel.com>:

> On Mon, Dec 04, 2017 at 03:54:18PM -0600, Gustavo A. R. Silva wrote:
>> crtc_state is being null checked in a previous code block, which implies
>> that such pointer might be null.
>>
>> crtc_state is dereferenced in drm_atomic_helper_check_plane_state, hence
>> there is a potential null pointer dereference.
>
> This is a false positive. drm_atomic_helper_check_plane_state() will not
> dereference crtc_state when plane_state->crtc is NULL.
>

You are right.

Thank you for clarifying.
--
Gustavo A. R. Silva