linux-kernel - Re: [PATCH] writeback: fix comment in __mark_inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171205154831.GR2421075@devbig577.frc2.facebook.com>
Date:   Tue, 5 Dec 2017 07:48:31 -0800
From:   Tejun Heo <tj@...nel.org>
To:     Wang Long <wanglong19@...tuan.com>
Cc:     viro@...iv.linux.org.uk, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org, w@...qinren.net
Subject: Re: [PATCH] writeback: fix comment in __mark_inode_dirty

Hello, Wang.

On Tue, Dec 05, 2017 at 12:52:54AM -0500, Wang Long wrote:
> Signed-off-by: Wang Long <wanglong19@...tuan.com>
> ---
>  fs/fs-writeback.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
> index cea4836..8d477cf 100644
> --- a/fs/fs-writeback.c
> +++ b/fs/fs-writeback.c
> @@ -2209,7 +2209,7 @@ void __mark_inode_dirty(struct inode *inode, int flags)
>  			trace_writeback_dirty_inode_enqueue(inode);
>  
>  			/*
> -			 * If this is the first dirty inode for this bdi,
> +			 * If this is the first dirty inode for this wb,

Acked-by: Tejun Heo <tj@...nel.org>

This probably should go through the block tree tho.  Please cc Jens
Axboe.

Thanks.

-- 
tejun