linux-kernel - Re: [PATCH v2 03/15] NTB: Fix UB/bug in ntb_mw_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPoiz9yPMBCwv0gvUgWbJj_Ue-67w6h0JyGALtx=E_4Hpbh+eA@mail.gmail.com>
Date:   Tue, 5 Dec 2017 12:08:23 -0500
From:   Jon Mason <jdmason@...zu.us>
To:     Logan Gunthorpe <logang@...tatee.com>
Cc:     Serge Semin <fancer.lancer@...il.com>,
        Dave Jiang <dave.jiang@...el.com>,
        "Hubbe, Allen" <Allen.Hubbe@....com>,
        "S-k, Shyam-sundar" <Shyam-sundar.S-k@....com>,
        "Yu, Xiangliang" <Xiangliang.Yu@....com>,
        Gary R Hook <gary.hook@....com>, Sergey.Semin@...latforms.ru,
        linux-ntb <linux-ntb@...glegroups.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 03/15] NTB: Fix UB/bug in ntb_mw_get_align()

On Tue, Dec 5, 2017 at 12:01 PM, Logan Gunthorpe <logang@...tatee.com> wrote:
>
>
> On 05/12/17 09:52 AM, Jon Mason wrote:
>>
>> On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin <fancer.lancer@...il.com>
>> wrote:
>>>
>>> Simple (1 << pidx) operation causes undefined behaviour when
>>> pidx >= 32. It must be casted to u64 to match the actual return
>>> value of ntb_link_is_up() method, so to have all the possible
>>> peer indexes covered and to get rid of undefined behaviour.
>>> Additionally there are special macros in "linux/bitops.h" to perform
>>> the bit-set-shift operations, so it's recommended to have them used
>>> for proper bit setting.
>>
>>
>> This looks good to me, but also seems like a bug fix.  Please comment
>> on if this is not noticed.
>
>
> It would be a bug on any system that has more than 32 partitions which is
> run on a 32 bit machine (or 64 partitions on a 64bit machine). Such a system
> is theoretical for the foreseeable future. But it would be good to fix it
> now.

Seems like a non-issue then.  Disregard.

>
> Logan
>
> --
> You received this message because you are subscribed to the Google Groups
> "linux-ntb" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to linux-ntb+unsubscribe@...glegroups.com.
> To post to this group, send email to linux-ntb@...glegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/linux-ntb/8859c11b-6c6b-3780-c13a-2ae0affd7033%40deltatee.com.
> For more options, visit https://groups.google.com/d/optout.