linux-kernel - Re: efi/esrt: use memunmap rather kfree to free the remapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKv+Gu_eSBvMh+hbU0iFwOuwKZw4AMnfss7pTu-Ya-QE5Xzn1Q@mail.gmail.com>
Date:   Tue, 5 Dec 2017 18:08:27 +0000
From:   Ard Biesheuvel <ard.biesheuvel@...aro.org>
To:     Pan Bian <bianpan2016@....com>
Cc:     Matt Fleming <matt@...eblueprint.co.uk>,
        "linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: efi/esrt: use memunmap rather kfree to free the remapping

On 29 October 2017 at 14:51, Pan Bian <bianpan2016@....com> wrote:
> The remapping result of memremap should be freed with memunmap, not
> kfree.
>
> Signed-off-by: Pan Bian <bianpan2016@....com>
> ---
>  drivers/firmware/efi/esrt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/efi/esrt.c b/drivers/firmware/efi/esrt.c
> index bd7ed3c..3ef7001 100644
> --- a/drivers/firmware/efi/esrt.c
> +++ b/drivers/firmware/efi/esrt.c
> @@ -431,7 +431,7 @@ static int __init esrt_sysfs_init(void)
>  err_remove_esrt:
>         kobject_put(esrt_kobj);
>  err:
> -       kfree(esrt);
> +       memunmap(esrt);
>         esrt = NULL;
>         return error;
>  }
> --
> 1.9.1
>

Queued in efi/urgent. Thanks.