lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20171206192026.25133-1-surenb@google.com> Date: Wed, 6 Dec 2017 11:20:26 -0800 From: Suren Baghdasaryan <surenb@...gle.com> To: akpm@...ux-foundation.org, mhocko@...e.com, hannes@...xchg.org, hillf.zj@...baba-inc.com, minchan@...nel.org, mgorman@...hsingularity.net, ying.huang@...el.com, linux-mm@...ck.org, linux-kernel@...r.kernel.org Cc: timmurray@...gle.com, tkjos@...gle.com, Suren Baghdasaryan <surenb@...gle.com> Subject: [PATCH] mm: terminate shrink_slab loop if signal is pending Slab shrinkers can be quite time consuming and when signal is pending they can delay handling of the signal. If fatal signal is pending there is no point in shrinking that process since it will be killed anyway. This change checks for pending fatal signals inside shrink_slab loop and if one is detected terminates this loop early. Signed-off-by: Suren Baghdasaryan <surenb@...gle.com> --- mm/vmscan.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/mm/vmscan.c b/mm/vmscan.c index c02c850ea349..69296528ff33 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -486,6 +486,13 @@ static unsigned long shrink_slab(gfp_t gfp_mask, int nid, .memcg = memcg, }; + /* + * We are about to die and free our memory. + * Stop shrinking which might delay signal handling. + */ + if (unlikely(fatal_signal_pending(current)) + break; + /* * If kernel memory accounting is disabled, we ignore * SHRINKER_MEMCG_AWARE flag and call all shrinkers -- 2.15.1.424.g9478a66081-goog
Powered by blists - more mailing lists