linux-kernel - [tip:core/urgent] cpu/hotplug: Fix state name in takedown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 6 Dec 2017 12:27:55 -0800
From:   tip-bot for Brendan Jackman <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     bigeasy@...utronix.de, brendan.jackman@....com,
        peterz@...radead.org, quentin.perret@....com, tglx@...utronix.de,
        dietmar.eggemann@....com, boris.ostrovsky@...cle.com,
        mingo@...nel.org, linux-kernel@...r.kernel.org,
        torvalds@...ux-foundation.org, hpa@...or.com
Subject: [tip:core/urgent] cpu/hotplug: Fix state name in takedown_cpu()
 comment

Commit-ID:  5b1ead6800cb2241aeadcba32736c5836e59c7e1
Gitweb:     https://git.kernel.org/tip/5b1ead6800cb2241aeadcba32736c5836e59c7e1
Author:     Brendan Jackman <brendan.jackman@....com>
AuthorDate: Wed, 6 Dec 2017 10:59:11 +0000
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Wed, 6 Dec 2017 19:28:45 +0100

cpu/hotplug: Fix state name in takedown_cpu() comment

CPUHP_AP_SCHED_MIGRATE_DYING doesn't exist, it looks like this was
supposed to refer to CPUHP_AP_SCHED_STARTING's teardown callback,
i.e. sched_cpu_dying().

Signed-off-by: Brendan Jackman <brendan.jackman@....com>
Cc: Boris Ostrovsky <boris.ostrovsky@...cle.com>
Cc: Dietmar Eggemann <dietmar.eggemann@....com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Quentin Perret <quentin.perret@....com>
Cc: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc: Thomas Gleixner <tglx@...utronix.de>
Link: http://lkml.kernel.org/r/20171206105911.28093-1-brendan.jackman@arm.com
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 kernel/cpu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/cpu.c b/kernel/cpu.c
index 04892a8..2a885c5 100644
--- a/kernel/cpu.c
+++ b/kernel/cpu.c
@@ -780,8 +780,8 @@ static int takedown_cpu(unsigned int cpu)
 	BUG_ON(cpu_online(cpu));
 
 	/*
-	 * The CPUHP_AP_SCHED_MIGRATE_DYING callback will have removed all
-	 * runnable tasks from the cpu, there's only the idle task left now
+	 * The teardown callback for CPUHP_AP_SCHED_STARTING will have removed
+	 * all runnable tasks from the CPU, there's only the idle task left now
 	 * that the migration thread is done doing the stop_machine thing.
 	 *
 	 * Wait for the stop thread to go away.