linux-kernel - Re: [PATCH] x86/mm/kaiser: avoid 32-bit/PAE build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171206210257.xlijytwuhnpsh7he@gmail.com>
Date:   Wed, 6 Dec 2017 22:02:57 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Dave Hansen <dave.hansen@...ux.intel.com>,
        the arch/x86 maintainers <x86@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86/mm/kaiser: avoid 32-bit/PAE build warning


* Arnd Bergmann <arnd@...db.de> wrote:

> On Wed, Dec 6, 2017 at 6:16 PM, Ingo Molnar <mingo@...nel.org> wrote:
> >
> > * Arnd Bergmann <arnd@...db.de> wrote:
> >
> >> On Wed, Dec 6, 2017 at 4:08 PM, Dave Hansen <dave.hansen@...ux.intel.com> wrote:
> >> > On 12/06/2017 07:03 AM, Arnd Bergmann wrote:
> >> >> On Wed, Dec 6, 2017 at 3:15 PM, Arnd Bergmann <arnd@...db.de> wrote:
> >> >>
> >> >> Maybe it's better to just to the last one-line change in include/linux/kaiser.h.
> >> >
> >> > Hi Arnd,
> >> >
> >> > Are you hitting this in -next?
> >> >
> >> > The newest version of this code has a single kpti_init() function that
> >> > shouldn't have any of these problems.
> >>
> >> Yes, this is next-20171206, apparently it came in through tip/auto-latest,
> >> which still has the same version.
> >
> > I'll update the -next version probably later today.
> 
> Thanks!
> 
>  I just ran into another build error with KAISER:
> 
> arch/x86/mm/kaiser.c:173:28: error: '__GFP_NOTRACK' undeclared (first
> use in this function); did you mean '__GFP_NOFAIL'?
> 
> When you do the update, can you check that it doesn't reference __GFP_NOTRACK?
> Apparently the flag got removed in 4.15-rc1.

Yeah, saw it too and fixed this one as well.

Thanks,

	Ingo