lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20171206.163814.2298864765495270615.davem@davemloft.net> Date: Wed, 06 Dec 2017 16:38:14 -0500 (EST) From: David Miller <davem@...emloft.net> To: ivan.khoronzhuk@...aro.org Cc: grygorii.strashko@...com, netdev@...r.kernel.org, linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH net-next] net: ethernet: ti: cpdma: correct error handling for chan create From: Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org> Date: Wed, 6 Dec 2017 16:54:09 +0200 > @@ -3065,10 +3065,16 @@ static int cpsw_probe(struct platform_device *pdev) > } > > cpsw->txv[0].ch = cpdma_chan_create(cpsw->dma, 0, cpsw_tx_handler, 0); > + if (WARN_ON(IS_ERR(cpsw->txv[0].ch))) { > + dev_err(priv->dev, "error initializing tx dma channel\n"); > + ret = PTR_ERR(cpsw->txv[0].ch); > + goto clean_dma_ret; > + } > + You're already emitting a proper dev_err() message, therefore WARN_ON() is a duplicate notification to the logs and therefore not appropriate.
Powered by blists - more mailing lists