linux-kernel - Re: [PATCH v4 2/2] dt-bindings: add eeprom "at24,no-read-rollover" property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171206220404.oyqg6ckhdx7jtbxw@rob-hp-laptop>
Date:   Wed, 6 Dec 2017 16:04:04 -0600
From:   Rob Herring <robh@...nel.org>
To:     Sven Van Asbroeck <svendev@...x.com>
Cc:     mark.rutland@....com, wsa@...-dreams.de, brgl@...ev.pl,
        nsekhar@...com, sakari.ailus@...ux.intel.com, david@...hnology.com,
        javier@...hile0.org, divagar.mohandass@...el.com,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-i2c@...r.kernel.org
Subject: Re: [PATCH v4 2/2] dt-bindings: add eeprom "at24,no-read-rollover"
 property

On Tue, Dec 05, 2017 at 10:23:42AM -0500, Sven Van Asbroeck wrote:
> Adds an optional property for at24 eeproms.
> This parameterless property indicates that the multi-address eeprom
> does not automatically roll over reads to the next slave address.
> 
> Signed-off-by: Sven Van Asbroeck <svendev@...x.com>
> ---
>  Documentation/devicetree/bindings/eeprom/eeprom.txt | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/eeprom/eeprom.txt b/Documentation/devicetree/bindings/eeprom/eeprom.txt
> index 27f2bc1..5bfc0ac 100644
> --- a/Documentation/devicetree/bindings/eeprom/eeprom.txt
> +++ b/Documentation/devicetree/bindings/eeprom/eeprom.txt
> @@ -38,6 +38,11 @@ Optional properties:
>  
>    - size: total eeprom size in bytes
>  
> +  - at24,no-read-rollover:

at24 is not a vendor prefix. Either this is atmel specific and you want 
atmel,no-read-rollover or it is for all vendors at24 compatible eeproms 
and you want at24-no-read-rollover. Or just drop the at24 if this 
binding is in fact for just at24 eeproms as none of the other properties 
has at24 in them.

> +			This parameterless property indicates that the multi-address
> +			eeprom does not automatically roll over reads to the next
> +			slave address. Please consult the manual of your device.
> +
>  Example:
>  
>  eeprom@52 {
> -- 
> 1.9.1
>