linux-kernel - RE: [PATCHv2 0/2] mtd: m25p80: restore the addressing mode when stop using the flash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 6 Dec 2017 02:17:36 +0000
From:   "Z.q. Hou" <zhiqiang.hou@....com>
To:     Cyrille Pitchen <cyrille.pitchen@...ev4u.fr>,
        "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "computersforpeace@...il.com" <computersforpeace@...il.com>,
        "dwmw2@...radead.org" <dwmw2@...radead.org>,
        "boris.brezillon@...e-electrons.com" 
        <boris.brezillon@...e-electrons.com>,
        "marek.vasut@...il.com" <marek.vasut@...il.com>,
        "richard@....at" <richard@....at>
Subject: RE: [PATCHv2 0/2] mtd: m25p80: restore the addressing mode when stop
 using the flash

Hi Cyrille,

Thanks a lot for your comments!

> -----Original Message-----
> From: Cyrille Pitchen [mailto:cyrille.pitchen@...ev4u.fr]
> Sent: 2017年12月6日 4:41
> To: Z.q. Hou <zhiqiang.hou@....com>; linux-mtd@...ts.infradead.org;
> linux-kernel@...r.kernel.org; computersforpeace@...il.com;
> dwmw2@...radead.org; boris.brezillon@...e-electrons.com;
> marek.vasut@...il.com; richard@....at
> Subject: Re: [PATCHv2 0/2] mtd: m25p80: restore the addressing mode when
> stop using the flash
> 
> Hi Hou,
> 
> Le 05/12/2017 à 06:33, Zhiqiang Hou a écrit :
> > From: Hou Zhiqiang <Zhiqiang.Hou@....com>
> >
> > To be compatible with legacy device, reset the addressing mode to the
> > default mode. Such as Freescale eSPI boot, it copies the images from
> > SPI flash without firing a reset signal previously, so the reboot
> > command will fail without reseting the addressing mode of SPI flash.
> >
> 
> You should put this in one of the commit messages so it explains which issue is
> fixed by your patches.

Agree with you, and will do it in next version.

> 
> Otherwise, your series looks good to me :)
> 
> Best regards,
> 
> Cyrille
> 
> > Hou Zhiqiang (2):
> >   mtd: spi-nor: add an API to restore the status of SPI flash chip
> >   mtd: m25p80: restore the status of SPI flash when stop using it
> >
> >  Documentation/mtd/spi-nor.txt |  3 +++  drivers/mtd/devices/m25p80.c
> > |  9 +++++++++  drivers/mtd/spi-nor/spi-nor.c | 10 ++++++++++
> >  include/linux/mtd/spi-nor.h   |  6 ++++++
> >  4 files changed, 28 insertions(+)
> >

Thanks,
Zhiqiang