linux-kernel - Re: add_wait_queue() (unintentional?) behavior change in v4.13

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 5 Dec 2017 18:35:12 -0800
From:   Fubo Chen <fubo.chen@...il.com>
To:     Omar Sandoval <osandov@...ndov.com>
Cc:     Ingo Molnar <mingo@...nel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Linux Kernel <linux-kernel@...r.kernel.org>,
        Jens Axboe <axboe@...com>
Subject: Re: add_wait_queue() (unintentional?) behavior change in v4.13

On Wed, Nov 29, 2017 at 4:58 PM, Omar Sandoval <osandov@...ndov.com> wrote:
> diff --git a/kernel/sched/wait.c b/kernel/sched/wait.c
> index 98feab7933c7..929ecb7d6b78 100644
> --- a/kernel/sched/wait.c
> +++ b/kernel/sched/wait.c
> @@ -27,7 +27,7 @@ void add_wait_queue(struct wait_queue_head *wq_head, struct wait_queue_entry *wq
>
>         wq_entry->flags &= ~WQ_FLAG_EXCLUSIVE;
>         spin_lock_irqsave(&wq_head->lock, flags);
> -       __add_wait_queue_entry_tail(wq_head, wq_entry);
> +       __add_wait_queue(wq_head, wq_entry);
>         spin_unlock_irqrestore(&wq_head->lock, flags);
>  }
>  EXPORT_SYMBOL(add_wait_queue);

Reviewed-by: Fubo Chen <fubo.chen@...il.com>