lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed,  6 Dec 2017 12:07:18 +0900
From:   Masami Hiramatsu <>
To:     Arnaldo Carvalho de Melo <>
Cc:     Masami Hiramatsu <>,
        bhargavb <>,, Paul Clarke <>,,
Subject: [PATCH 2/5] perf-probe: Cut off the version suffix from event name

Cut off the version suffix (e.g. @GLIBC_2.2.5 etc.) from
automatic generated event name. This fixes wildcard event
adding like below case;

  # perf probe -x /lib64/ malloc*
  Internal error: "malloc_get_state@...BC_2" is wrong event name.
    Error: Failed to add events.

This failure was caused by a versioned suffix symbol.
With this fix, perf probe automatically cuts the
suffix after @ as below.

  # ./perf probe -x /lib64/ malloc*
  Added new events:
    probe_libc:malloc_printerr (on malloc* in /usr/lib64/
    probe_libc:malloc_consolidate (on malloc* in /usr/lib64/
    probe_libc:malloc_check (on malloc* in /usr/lib64/
    probe_libc:malloc_hook_ini (on malloc* in /usr/lib64/
    probe_libc:malloc    (on malloc* in /usr/lib64/
    probe_libc:malloc_trim (on malloc* in /usr/lib64/
    probe_libc:malloc_usable_size (on malloc* in /usr/lib64/
    probe_libc:malloc_stats (on malloc* in /usr/lib64/
    probe_libc:malloc_info (on malloc* in /usr/lib64/
    probe_libc:mallochook (on malloc* in /usr/lib64/
    probe_libc:malloc_get_state (on malloc* in /usr/lib64/
    probe_libc:malloc_set_state (on malloc* in /usr/lib64/

  You can now use it in all perf tools, such as:

	  perf record -e probe_libc:malloc_set_state -aR sleep 1


Signed-off-by: Masami Hiramatsu <>
Reported-by: Arnaldo Carvalho de Melo <>
Reported-by: bhargavb <>
 tools/perf/util/probe-event.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
index c0067950e56f..74435fb7ab7f 100644
--- a/tools/perf/util/probe-event.c
+++ b/tools/perf/util/probe-event.c
@@ -2584,8 +2584,8 @@ static int get_new_event_name(char *buf, size_t len, const char *base,
 	if (!nbase)
 		return -ENOMEM;
-	/* Cut off the dot suffixes (e.g. .const, .isra)*/
-	p = strchr(nbase, '.');
+	/* Cut off the dot suffixes (e.g. .const, .isra) and version suffixes */
+	p = strpbrk(nbase, ".@");
 	if (p && p != nbase)
 		*p = '\0';

Powered by blists - more mailing lists