linux-kernel - [PATCH] usbip: vhci_hcd: print correct info in default case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed,  6 Dec 2017 11:43:04 +0800
From:   Pei Zhang <pei.zhang@...el.com>
To:     linux-kernel@...r.kernel.org, usbip-devel@...ts.sourceforge.net
Cc:     Pei Zhang <pei.zhang@...el.com>
Subject: [PATCH] usbip: vhci_hcd: print correct info in default case

In this switch-case logical, 2 cases will goes to default case.
The default log should exclude the upper 2 cases.

Signed-off-by: Pei Zhang <pei.zhang@...el.com>
---
 drivers/usb/usbip/vhci_hcd.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c
index 0585078..b0057ac 100644
--- a/drivers/usb/usbip/vhci_hcd.c
+++ b/drivers/usb/usbip/vhci_hcd.c
@@ -406,7 +406,9 @@ static int vhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue,
 
 			/* FALLTHROUGH */
 		default:
-			usbip_dbg_vhci_rh(" SetPortFeature: default %d\n",
+			if (wValue != USB_PORT_FEAT_SUSPEND &&
+				wValue != USB_PORT_FEAT_RESET)
+				usbip_dbg_vhci_rh(" SetPortFeature: default %d\n",
 					  wValue);
 			dum->port_status[rhport] |= (1 << wValue);
 			break;
-- 
2.7.4