linux-kernel - Re: [PATCH v4 3/3] powerpc/modules: Improve restore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87374ofpdq.fsf@concordia.ellerman.id.au>
Date:   Wed, 06 Dec 2017 15:32:01 +1100
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
Cc:     Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>,
        linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        live-patching@...r.kernel.org,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Balbir Singh <bsingharora@...il.com>
Subject: Re: [PATCH v4 3/3] powerpc/modules: Improve restore_r2() error message

Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com> writes:

> From: Josh Poimboeuf <jpoimboe@...hat.com>
>
> Print the function address associated with the restore_r2() error to
> make it easier to debug the problem.
>
> Also clarify the wording a bit.
>
> Before:
>
>   module_64: patch_foo: Expect noop after relocate, got 3c820000
>
> After:
>
>   module_64: patch_foo: Expected noop after call, got 7c630034 at netdev_has_upper_dev+0x54/0xb0 [patch_foo]

I renamed noop to nop, as that's the name of the instruction.

cheers