linux-kernel - Re: [PATCH V11 4/5] vsprintf: add printk specifier %px

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFzTxWLvCF7jDLOtLDRRP+_E1D=8E41PPQUq4LS+bZk2vg@mail.gmail.com>
Date:   Tue, 5 Dec 2017 20:40:02 -0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Alexey Dobriyan <adobriyan@...il.com>
Cc:     Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        tcharding <me@...in.cc>
Subject: Re: [PATCH V11 4/5] vsprintf: add printk specifier %px

On Tue, Dec 5, 2017 at 8:19 PM, Alexey Dobriyan <adobriyan@...il.com> wrote:
> Because people who introduce this stupid %p hashing can't be bothered
> to actually audit users:

I don't see you having offered to audit the 12k+ cases, did you?

So maybe it's easier to just change them all, and then the handful
that breaks can be fixed?

Do you maybe want to re-think that "stupid" comment?

Or are you going to spend the time to audit all those other %p users,
particularly considering that we _know_ a number of them are bad?

Once you've done that, and offered to keep doing it, we can undo the hashing.

I'll be waiting.

             Linus