linux-kernel - Re: [PATCH] ARM: dts: introduce the sama5d2 ptc ek board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171206070132.GE2451@rfolt0960.corp.atmel.com>
Date:   Wed, 6 Dec 2017 08:01:32 +0100
From:   Ludovic Desroches <ludovic.desroches@...rochip.com>
To:     Baruch Siach <baruch@...s.co.il>
CC:     Ludovic Desroches <ludovic.desroches@...rochip.com>,
        <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <alexandre.belloni@...e-electrons.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: dts: introduce the sama5d2 ptc ek board

On Tue, Dec 05, 2017 at 07:01:41PM +0200, Baruch Siach wrote:
> Hi Ludovic,
> 
> On Tue, Dec 05, 2017 at 03:23:12PM +0100, Ludovic Desroches wrote:
> > Add the official SAMA5D2 Peripheral Touch Controller Evaluation
> > Kit board.
> > 
> > Signed-off-by: Ludovic Desroches <ludovic.desroches@...rochip.com>
> > ---
> 
> [...]
> 
> > +	memory {
> > +		reg = <0x20000000 0x80000>;
> > +	};
> 
> The size value is clearly wrong; you surely don't run on 512KB RAM. You most 
> likely rely on the bootloader to fix the size value. Since sama5d2.dtsi has a 
> memory node already with the same address, you can just drop it from here.
> 

Thanks, fixed in v2.

Ludovic

> baruch
> 
> -- 
>      http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
>    - baruch@...s.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -