linux-kernel - RE: [PATCH] xen-netback: Fix logging message with spurious period after newline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1f7b9f45512d4b84b1775efe88a3eb98@AMSPEX02CL03.citrite.net>
Date:   Wed, 6 Dec 2017 09:30:17 +0000
From:   Paul Durrant <Paul.Durrant@...rix.com>
To:     'Joe Perches' <joe@...ches.com>, Wei Liu <wei.liu2@...rix.com>
CC:     "xen-devel@...ts.xenproject.org" <xen-devel@...ts.xenproject.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] xen-netback: Fix logging message with spurious period
 after newline

> -----Original Message-----
> From: Joe Perches [mailto:joe@...ches.com]
> Sent: 06 December 2017 06:40
> To: Wei Liu <wei.liu2@...rix.com>; Paul Durrant <Paul.Durrant@...rix.com>
> Cc: xen-devel@...ts.xenproject.org; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: [PATCH] xen-netback: Fix logging message with spurious period
> after newline
> 
> Using a period after a newline causes bad output.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

Reviewed-by: Paul Durrant <paul.durrant@...rix.com>

> ---
>  drivers/net/xen-netback/interface.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-
> netback/interface.c
> index d6dff347f896..78ebe494fef0 100644
> --- a/drivers/net/xen-netback/interface.c
> +++ b/drivers/net/xen-netback/interface.c
> @@ -186,7 +186,7 @@ static int xenvif_start_xmit(struct sk_buff *skb, struct
> net_device *dev)
>  	/* Obtain the queue to be used to transmit this packet */
>  	index = skb_get_queue_mapping(skb);
>  	if (index >= num_queues) {
> -		pr_warn_ratelimited("Invalid queue %hu for packet on
> interface %s\n.",
> +		pr_warn_ratelimited("Invalid queue %hu for packet on
> interface %s\n",
>  				    index, vif->dev->name);
>  		index %= num_queues;
>  	}
> --
> 2.15.0