linux-kernel - Re: [Nouveau] [PATCH] drm/nouveau/mmu: fix odd_ptr_err.cocci warnings

Open Source and information security mailing list archives

Message-ID: <CACO55tvtihGO8PatjshOo7JBqo1WHFFFgO07TVu5261c1aeB_w@mail.gmail.com>
Date:   Wed, 6 Dec 2017 11:02:00 +0100
From:   Karol Herbst <kherbst@...hat.com>
To:     Christoph Böhmwalder <christoph@...hmwalder.at>
Cc:     Ben Skeggs <bskeggs@...hat.com>, David Airlie <airlied@...ux.ie>,
        nouveau <nouveau@...ts.freedesktop.org>,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [Nouveau] [PATCH] drm/nouveau/mmu: fix odd_ptr_err.cocci warnings

Reviewed-by: Karol Herbst <kherbst@...hat.com>

On Thu, Nov 30, 2017 at 8:53 PM, Christoph Böhmwalder
<christoph@...hmwalder.at> wrote:
> The kbuild test bot complained about a new coccinelle warning nearby,
> which sparked a discussion about the assignment to 'memory' inside of
> the conditional expression.  See Link below for the original post.
>
> Fix the assignment to silence the coccinelle warning and also make the
> code look a little nicer.
>
> Link: https://lists.freedesktop.org/archives/nouveau/2017-November/029242.html
> Signed-off-by: Christoph Böhmwalder <christoph@...hmwalder.at>
> ---
>  drm/nouveau/nvkm/subdev/mmu/uvmm.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drm/nouveau/nvkm/subdev/mmu/uvmm.c b/drm/nouveau/nvkm/subdev/mmu/uvmm.c
> index fa81d0c1..37b201b9 100644
> --- a/drm/nouveau/nvkm/subdev/mmu/uvmm.c
> +++ b/drm/nouveau/nvkm/subdev/mmu/uvmm.c
> @@ -106,7 +106,8 @@ nvkm_uvmm_mthd_map(struct nvkm_uvmm *uvmm, void *argv, u32 argc)
>         } else
>                 return ret;
>
> -       if (IS_ERR((memory = nvkm_umem_search(client, handle)))) {
> +       memory = nvkm_umem_search(client, handle);
> +       if (IS_ERR(memory)) {
>                 VMM_DEBUG(vmm, "memory %016llx %ld\n", handle, PTR_ERR(memory));
>                 return PTR_ERR(memory);
>         }
> --
> 2.13.6
>
> _______________________________________________
> Nouveau mailing list
> Nouveau@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/nouveau

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives