lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 6 Dec 2017 13:14:37 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     rodrigosiqueira <rodrigosiqueiramelo@...il.com>
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Scheduler: Removed first parameter from
 prepare_lock_switch

On Tue, Dec 05, 2017 at 12:02:00PM -0200, rodrigosiqueira wrote:
> The first parameter of prepare_lock_switch (kernel/sched/sched.h) is not
> used anymore. Commit c55f5158f removed the code that use the first
> parameter and function prepare_lock_switch is only used in
> prepare_task_switch (kernel/sched/core.c)

Yes, this is correct. However it had me looking at that code and pretty
much everything else is completely wrong :-)

That is, its functionally correct (probably), but the function name is
not descriptive of what the function does and the comment is just plain
wrong.

Also, since both functions are only used in core.c we should probably
move them there.

Do you think you can fix all that as well?

Powered by blists - more mailing lists