linux-kernel - Re: [PATCH v2] Staging: pi433: fix brace coding style issues in pi433

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171206150123.GA9143@kroah.com>
Date:   Wed, 6 Dec 2017 16:01:23 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Tomas Marek <marek_tomas@...trum.cz>
Cc:     devel@...verdev.osuosl.org, joe@...ches.com,
        linux-kernel@...r.kernel.org, dan.carpenter@...cle.com
Subject: Re: [PATCH v2] Staging: pi433: fix brace coding style issues in
 pi433_if.c

On Mon, Dec 04, 2017 at 09:40:10PM +0100, Tomas Marek wrote:
> This patch fix several brace on next line, braces not necessary, space
> around =/<, and space before/after open/close parenthesis coding style
> errors find by checkpatch in pi433_if.c.
> 
> In addition, the interrupt routine DIO0_irq_handler logic is updated:
> - use 'switch' statement instead of 'if/else if' combination for the
>   sake of readability, and
> - use dev_dbg_ratelimited instead of dev_dbg to avoid message flooding.

When you have to add "in addition" to a changelog comment, that's a huge
flag that the patch needs to be broken up into a patch series.  Please
do that here, only doing one "logical" thing at a time.  As it is, it's
hard to review this way.

thanks,

greg k-h