linux-kernel - Re: [PATCH] x86/mm/kaiser: avoid 32-bit/PAE build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <af5124d4-b2cc-7d3c-5b8e-f7381859efd6@linux.intel.com>
Date:   Wed, 6 Dec 2017 07:08:56 -0800
From:   Dave Hansen <dave.hansen@...ux.intel.com>
To:     Arnd Bergmann <arnd@...db.de>,
        the arch/x86 maintainers <x86@...nel.org>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86/mm/kaiser: avoid 32-bit/PAE build warning

On 12/06/2017 07:03 AM, Arnd Bergmann wrote:
> On Wed, Dec 6, 2017 at 3:15 PM, Arnd Bergmann <arnd@...db.de> wrote:
> 
>> This changes the type to u64 in the architecture-independent dummy,
>> and to pteval_t in the x86 specific portion that is used when KAISER
>> is enabled, ensuring that the flags can always fit. Unfortunately,
>> pteval_t is not provided by most other architectures, so we are
>> a little bit inconsistent here.
> 
> I ran into a new regression with my patch applied, after doing more randconfig
> builds:
> 
> In file included from /git/arm-soc/include/linux/kaiser.h:5,
>                  from /git/arm-soc/arch/x86/events/intel/ds.c:4:
> arch/x86/include/asm/kaiser.h:34:10: error: unknown type name
> 'pteval_t'; did you mean 'dev_t'?
> 
> Maybe it's better to just to the last one-line change in include/linux/kaiser.h.

Hi Arnd,

Are you hitting this in -next?

The newest version of this code has a single kpti_init() function that
shouldn't have any of these problems.