lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20171206151903.GA11701@kroah.com> Date: Wed, 6 Dec 2017 16:19:03 +0100 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: Nguyen Phan Quang Minh <minhnpq16@...il.com> Cc: Dan Carpenter <dan.carpenter@...cle.com>, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: Re: [PATCHv2] staging: pi433: pi433_if.c remove SET_CHECKED macro On Sun, Dec 03, 2017 at 01:09:49AM +0100, Nguyen Phan Quang Minh wrote: > The macro calls its argument -a function- twice, makes the calling > function return prematurely -skipping resource cleanup code- and hurts > understandability. > > Signed-off-by: Nguyen Phan Quang Minh <minhnpq16@...il.com> > --- > Base on Dan's feedback, I checked and the macro return indeed skips over > some cleanup code, hence remove it. > The code is not pretty, any hints on how to do it better is greatly > appreciated. Please redo this based on Dan's comments. thanks, greg k-h
Powered by blists - more mailing lists