lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 6 Dec 2017 14:16:21 -0200
From:   "Guilherme G. Piccoli" <>
To:     SF Markus Elfring <>,
Cc:     Greg Kroah-Hartman <>,
        Joe Perches <>, Jiri Slaby <>,
        LKML <>,
Subject: Re: jsm_tty: Fix a possible null pointer dereference in two functions

On 11/29/2017 04:19 PM, SF Markus Elfring wrote:
>>> It's pretty unlikely, but it is an actual defect.
>> No it is not, those variables will never be set to NULL,
>> so this can never be triggered.  Walk up the call chain.
> If the involved software developers are convinced about the validity
> of this pointer:
> How do you think about to delete the following condition check
> instead in the discussed function implementations?
> 	if (!ch)
> 		return;
> Regards,
> Markus

Thanks for the fix.
I was on vacation - but now seeing all the analysis made here, if "ch"
can't be NULL then please go ahead and remove the check =)
I observed that this check comes from before Git, so really ancient code...



Powered by blists - more mailing lists