linux-kernel - Re: [PATCH v3 34/36] ALSA/dummy: Replace tasklet with softirq hrtimer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5ha7yvrfd6.wl-tiwai@suse.de>
Date:   Wed, 06 Dec 2017 17:27:33 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     "Anna-Maria Gleixner" <anna-maria@...utronix.de>
Cc:     "LKML" <linux-kernel@...r.kernel.org>,
        <alsa-devel@...a-project.org>, <keescook@...omium.org>,
        "Peter Zijlstra" <peterz@...radead.org>,
        "John Stultz" <john.stultz@...aro.org>,
        "Thomas Gleixner" <tglx@...utronix.de>,
        "Christoph Hellwig" <hch@....de>,
        "Jaroslav Kysela" <perex@...ex.cz>,
        "Ingo Molnar" <mingo@...hat.com>,
        "Takashi Sakamoto" <o-takashi@...amocchi.jp>
Subject: Re: [PATCH v3 34/36] ALSA/dummy: Replace tasklet with softirq hrtimer

On Wed, 29 Nov 2017 16:30:59 +0100,
Anna-Maria Gleixner wrote:
> 
> From: Thomas Gleixner <tglx@...utronix.de>
> 
> The tasklet is used to defer the execution of snd_pcm_period_elapsed() to
> the softirq context. Using the HRTIMER_MODE_SOFT mode invokes the timer
> callback in softirq context as well which renders the tasklet useless.
> 
> [o-takashi: avoid stall due to a call of hrtimer_cancel() on a callback
>             of hrtimer]
> 
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Signed-off-by: Anna-Maria Gleixner <anna-maria@...utronix.de>
> Cc: alsa-devel@...a-project.org
> Cc: Takashi Sakamoto <o-takashi@...amocchi.jp>
> Cc: Takashi Iwai <tiwai@...e.com>
> Cc: Jaroslav Kysela <perex@...ex.cz>
> Link: http://lkml.kernel.org/r/20170905161820.jtysvxtfleunbbmf@breakpoint.cc

Feel free to take my ack:
  Reviewed-by: Takashi Iwai <tiwai@...e.de>


thanks,

Takashi