linux-kernel - [PATCH] spi: sun4i: disable clocks in the remove function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1512583209-19398-1-git-send-email-takuo.koguchi.sw@hitachi.com>
Date:   Thu,  7 Dec 2017 03:00:00 +0900
From:   Takuo Koguchi <takuo.koguchi@...il.com>
To:     linux-kernel@...r.kernel.org, khoroshilov@...ras.ru,
        takuo.koguchi@...il.com
Cc:     Takuo Koguchi <takuo.koguchi.sw@...achi.com>,
        Mark Brown <broonie@...nel.org>,
        Maxime Ripard <maxime.ripard@...e-electrons.com>,
        Chen-Yu Tsai <wens@...e.org>, linux-spi@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: [PATCH] spi: sun4i: disable clocks in the remove function

mclk and hclk need to be disabled since pm_runtime_disable does
not disable the clocks.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Takuo Koguchi <takuo.koguchi.sw@...achi.com>
---
 V2: use pm_runtime_force_suspend to avoid unbalance disable
     call.
     Compile test only, no runtime test.
 drivers/spi/spi-sun4i.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/spi-sun4i.c b/drivers/spi/spi-sun4i.c
index c5cd635..ca733b2 100644
--- a/drivers/spi/spi-sun4i.c
+++ b/drivers/spi/spi-sun4i.c
@@ -525,6 +525,7 @@ static int sun4i_spi_probe(struct platform_device *pdev)
 
 static int sun4i_spi_remove(struct platform_device *pdev)
 {
+	pm_runtime_force_suspend(&pdev->dev);
 	pm_runtime_disable(&pdev->dev);
 
 	return 0;
-- 
2.7.4