linux-kernel - Re: [PATCH] ntb_hw_switchtec: fix logic error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6cdab766-60a2-0ef9-5495-f842acde8604@deltatee.com>
Date:   Wed, 6 Dec 2017 10:37:06 -0700
From:   Logan Gunthorpe <logang@...tatee.com>
To:     Arnd Bergmann <arnd@...db.de>,
        Kurt Schwemmer <kurt.schwemmer@...rosemi.com>,
        Jon Mason <jdmason@...zu.us>,
        Dave Jiang <dave.jiang@...el.com>,
        Allen Hubbe <Allen.Hubbe@....com>
Cc:     Stephen Bates <sbates@...thlin.com>,
        Colin Ian King <colin.king@...onical.com>,
        Doug Meyer <dmeyer@...aio.com>,
        Kelvin Cao <kelvin.cao@...rosemi.com>,
        linux-pci@...r.kernel.org, linux-ntb@...glegroups.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ntb_hw_switchtec: fix logic error

Hey,

Thanks, nice catch.

On 06/12/17 07:19 AM, Arnd Bergmann wrote:
> Newer gcc (version 7 and 8 presumably) warn about a statement mixing
> the << operator with logical and:
> 
> drivers/ntb/hw/mscc/ntb_hw_switchtec.c: In function 'switchtec_ntb_init_sndev':
> drivers/ntb/hw/mscc/ntb_hw_switchtec.c:888:24: error: '<<' in boolean context, did you mean '<' ? [-Werror=int-in-bool-context]
> 
> My interpretation here is that the author must have intended a bitmask
> rather than a comparison, so I'm changing the '&&' to '&', which makes
> a lot more sense in the context.
> 
> Fixes: 1b249475275d ("ntb_hw_switchtec: Allow using Switchtec NTB in multi-partition setups")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by: Logan Gunthorpe <logang@...tatee.com>

Logan