linux-kernel - Re: [PATCH] tools/usbip: fixes build with musl libc toolchain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6378931e-57f5-0960-9a88-53bcfbf8dc69@kernel.org>
Date:   Wed, 6 Dec 2017 11:17:51 -0700
From:   Shuah Khan <shuah@...nel.org>
To:     julien.boibessot@...e.fr,
        Valentina Manea <valentina.manea.m@...il.com>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Julien BOIBESSOT <julien.boibessot@...adeus.com>,
        Shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH] tools/usbip: fixes build with musl libc toolchain

On 12/05/2017 10:48 AM, julien.boibessot@...e.fr wrote:
> From: Julien BOIBESSOT <julien.boibessot@...adeus.com>
> 
> Indeed musl doesn't define old SIGCLD signal name but only new one SIGCHLD.
> SIGCHLD is the new POSIX name for that signal so it doesn't change
> anything on other libcs.
> 
> This fixes this kind of build error:
> 
> usbipd.c: In function ‘set_signal’:
> usbipd.c:459:12: error: 'SIGCLD' undeclared (first use in this function)
>   sigaction(SIGCLD, &act, NULL);
>             ^~~~~~
> usbipd.c:459:12: note: each undeclared identifier is reported only once
> 	for each function it appears in
> Makefile:407: recipe for target 'usbipd.o' failed
> make[3]: *** [usbipd.o] Error 1
> 
> Signed-off-by: Julien BOIBESSOT <julien.boibessot@...adeus.com>
> ---

Thanks for the patch.

Greg,

Please pick this up.

Acked-by: Shuah Khan <shuahkh@....samsung.com>

thanks,
-- Shuah