linux-kernel - Re: [PATCH] mm: terminate shrink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171207162525.GL20234@dhcp22.suse.cz>
Date:   Thu, 7 Dec 2017 17:25:25 +0100
From:   Michal Hocko <mhocko@...nel.org>
To:     Suren Baghdasaryan <surenb@...gle.com>
Cc:     Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Johannes Weiner <hannes@...xchg.org>, hillf.zj@...baba-inc.com,
        minchan@...nel.org, mgorman@...hsingularity.net,
        ying.huang@...el.com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, Tim Murray <timmurray@...gle.com>,
        Todd Kjos <tkjos@...gle.com>
Subject: Re: [PATCH] mm: terminate shrink_slab loop if signal is pending

On Thu 07-12-17 07:46:07, Suren Baghdasaryan wrote:
> I'm, terribly sorry. My original code was checking for additional
> condition which I realized is not useful here because it would mean
> the signal was already processed. Should have missed the error while
> removing it. Will address Michal's comments and fix the problem.

yes, rebasing at last moment tend to screw things... No worries, I would
be more worried about the general approach here and its documentataion.
-- 
Michal Hocko
SUSE Labs