linux-kernel - Re: [PATCH] spi: sun6i: disable/unprepare clocks on remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171207163627.i4nrojgveczjfeox@flea.lan>
Date:   Thu, 7 Dec 2017 17:36:27 +0100
From:   Maxime Ripard <maxime.ripard@...e-electrons.com>
To:     Tobias Jordan <Tobias.Jordan@...ktrobit.com>
Cc:     Mark Brown <broonie@...nel.org>, Chen-Yu Tsai <wens@...e.org>,
        linux-spi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, ldv-project@...uxtesting.org
Subject: Re: [PATCH] spi: sun6i: disable/unprepare clocks on remove

On Thu, Dec 07, 2017 at 03:04:53PM +0100, Tobias Jordan wrote:
> sun6i_spi_probe() uses sun6i_spi_runtime_resume() to prepare/enable
> clocks, so sun6i_spi_remove() should use sun6i_spi_runtime_suspend() to
> disable/unprepare them if we're not suspended.
> Replacing pm_runtime_disable() by pm_runtime_force_suspend() will ensure
> that sun6i_spi_runtime_suspend() is called if needed.
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Fixes: 3558fe900e8af spi: sunxi: Add Allwinner A31 SPI controller driver

This isn't the proper fixes format.

> Signed-off-by: Tobias Jordan <Tobias.Jordan@...ktrobit.com>

Once fixed,
Acked-by: Maxime Ripard <maxime.ripard@...e-electrons.com>

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)