linux-kernel - Re: linux-next: build failure after merge of the scsi-mkp tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171207152521.0036b131@canb.auug.org.au>
Date:   Thu, 7 Dec 2017 15:25:21 +1100
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Bart Van Assche <Bart.VanAssche@....com>
Cc:     "Martin K. Petersen" <martin.petersen@...cle.com>,
        Linus Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Pavel Tikhomirov <ptikhomirov@...tuozzo.com>,
        "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
        Josh Triplett <josh@...htriplett.org>
Subject: Re: linux-next: build failure after merge of the scsi-mkp tree

Hi Bart,

[cc'ing some RCU people ...]

On Thu, 7 Dec 2017 03:59:30 +0000 Bart Van Assche <Bart.VanAssche@....com> wrote:
>
> On Thu, 2017-12-07 at 14:57 +1100, Stephen Rothwell wrote:
> > After merging the scsi-mkp tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> > 
> > ERROR: "init_rcu_head" [drivers/scsi/scsi_mod.ko] undefined!
> > ERROR: "destroy_rcu_head" [drivers/scsi/scsi_mod.ko] undefined!
> > 
> > Caused by commit
> > 
> >   ac90420f17c9 ("scsi: core: Ensure that the SCSI error handler gets woken up")
> > 
> > I have used the scsi-mkp tree from next-20171206 for today.  
> 
> Does that mean I'm the first one who added RCU code to the SCSI core?

The only other uses of init_rcu_head() are in drivers/iommu/intel-svm.c
and kernel/irq/irqdesc.c.  destroy_rcu_head() appears to not be used
anywhere ...

-- 
Cheers,
Stephen Rothwell