linux-kernel - Re: [PATCH] staging: lustre: Fix sparse, using plain integer as NULL pointer in lov_object

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1512667487.960.46.camel@perches.com>
Date:   Thu, 07 Dec 2017 09:24:47 -0800
From:   Joe Perches <joe@...ches.com>
To:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        Andrii Vladyka <tulup@...l.ru>
Cc:     "Dilger, Andreas" <andreas.dilger@...el.com>,
        "Drokin, Oleg" <oleg.drokin@...el.com>,
        "jsimmons@...radead.org" <jsimmons@...radead.org>,
        "lustre-devel@...ts.lustre.org" <lustre-devel@...ts.lustre.org>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: lustre: Fix sparse, using plain integer as
 NULL pointer in lov_object_fiemap()

On Wed, 2017-12-06 at 09:53 +0100, gregkh@...uxfoundation.org wrote:
> On Mon, Dec 04, 2017 at 12:44:32PM +0200, Andrii Vladyka wrote:
> > Change 0 to NULL in lov_object_fiemap() in order to fix warning produced by
> > sparse
> > 
> > Signed-off-by: Andrii Vladyka <tulup@...l.ru>
> > Signed-off-by: Andreas Dilger <andreas.dilger@...el.com>
> > ---
> > 
> > diff --git a/drivers/staging/lustre/lustre/lov/lov_object.c b/drivers/staging/lustre/lustre/lov/lov_object.c
> > index 105b707..897cf2c 100644
> > --- a/drivers/staging/lustre/lustre/lov/lov_object.c
> > +++ b/drivers/staging/lustre/lustre/lov/lov_object.c
> > @@ -1335,7 +1335,7 @@ static int lov_object_fiemap(const struct lu_env *env, struct cl_object *obj,
> >  	int rc = 0;
> >  	int cur_stripe;
> >  	int stripe_count;
> > -	struct fiemap_state fs = { 0 };
> > +	struct fiemap_state fs = { NULL };
> >  	lsm = lov_lsm_addref(cl2lov(obj));
> >  	if (!lsm)
> 
> Patch is corrupted, and can not apply, please fix up your email client
> and try it again.

It would be better to use {} to clear the struct
rather than any member initialization.