linux-kernel - Re: [PATCH v2 3/3] checkpatch: warn for use of %px

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171207211539.GL2191@eros>
Date:   Fri, 8 Dec 2017 08:15:39 +1100
From:   "Tobin C. Harding" <me@...in.cc>
To:     Joe Perches <joe@...ches.com>
Cc:     Andy Whitcroft <apw@...onical.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/3] checkpatch: warn for use of %px

On Fri, Dec 08, 2017 at 08:06:53AM +1100, Tobin C. Harding wrote:
> On Wed, Dec 06, 2017 at 02:37:08PM +1100, Tobin C. Harding wrote:
> > Usage of the new %px specifier potentially leaks sensitive
> > inforamtion. Printing kernel addresses exposes the kernel layout in
> > memory, this is potentially exploitable. We have tools in the kernel to
> > help us do the right thing. We can have checkpatch warn developers of
> > potential dangers of using %px.
> > 
> > Have checkpatch emit a warning for usage of specifier %px.
> > 
> > Signed-off-by: Tobin C. Harding <me@...in.cc>
> > Co-developed-by: Joe Perches <joe@...ches.com>
> 
>   Co-Developed-by:
> 
> Woops.
> 
> Joe I didn't quite understand what you meant when you said that this
> could go in via any tree. I'm still learning the whole kernel tree
> management thing. Don't checkpatch patches go in via Andy's tree?
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/apw/checkpatch.git/

Oh, I see that tree is not super active. If there are no NACK's do you
want me to put this through my tree? Perhaps once the Co-Developed-by
stuff is in an acceptable form we could put them all together? Please do
say if I'm going about things wrong, here to learn.

thanks,
Tobin.