linux-kernel - Re: [Part2 PATCH v9 12/38] crypto: ccp: Add Platform Security Processor (PSP) device support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOFm3uGqTZa9forFDFWdnGOx9z2OwEh0=jzL5U11=STqgPkxkA@mail.gmail.com>
Date:   Thu, 7 Dec 2017 22:20:49 +0100
From:   Philippe Ombredanne <pombredanne@...b.com>
To:     Brijesh Singh <brijesh.singh@....com>
Cc:     kvm@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        x86@...nel.org, bp@...en8.de, Paolo Bonzini <pbonzini@...hat.com>,
        Radim Krčmář <rkrcmar@...hat.com>,
        Borislav Petkov <bp@...e.de>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Gary Hook <gary.hook@....com>,
        Tom Lendacky <thomas.lendacky@....com>,
        linux-crypto@...r.kernel.org
Subject: Re: [Part2 PATCH v9 12/38] crypto: ccp: Add Platform Security
 Processor (PSP) device support

On Thu, Dec 7, 2017 at 9:21 PM, Brijesh Singh <brijesh.singh@....com> wrote:
>
>
> On 12/06/2017 03:10 PM, Philippe Ombredanne wrote:>> diff --git
> a/drivers/crypto/ccp/psp-dev.c b/drivers/crypto/ccp/psp-dev.c
>>>
>>> new file mode 100644
>>> index 000000000000..b5789f878560
>>> --- /dev/null
>>> +++ b/drivers/crypto/ccp/psp-dev.c
>>> @@ -0,0 +1,105 @@
>>> +/*
>>> + * AMD Platform Security Processor (PSP) interface
>>> + *
>>> + * Copyright (C) 2016-2017 Advanced Micro Devices, Inc.
>>> + *
>>> + * Author: Brijesh Singh <brijesh.singh@....com>
>>> + *
>>> + * This program is free software; you can redistribute it and/or modify
>>> + * it under the terms of the GNU General Public License version 2 as
>>> + * published by the Free Software Foundation.
>>> + */
>>
>>
>> Dear Brijesh,
>>
>> Have you considered using the new SPDX license ids instead?
>>
>> This would come out this way:
>>>
>>> +// SDPX-License-Identifier: GPL-2.0
>>> +/*
>>> + * AMD Platform Security Processor (PSP) interface
>>> + *
>>> + * Copyright (C) 2016-2017 Advanced Micro Devices, Inc.
>>> + *
>>> + * Author: Brijesh Singh <brijesh.singh@....com>
>>> + */
>>
>>
>> It is much cleaner and simpler, right?
>>
>> For the C++ comment style and first line placement, please see Thomas
>> (tlgx) doc patches and Linus posts explaining his rationale of why he
>> wants it this way.
>> It would be awesome if this could be applied to all AMD contributions btw!
>>
>
> Hi Philippe,
>
> I was not aware of SPDX identifier, If v10 is needed for SEV series then I
> will certainly update the patches to use SPDX license identifier. thanks


Brijesh, that's very kind of you!

-- 
Cordially
Philippe Ombredanne