linux-kernel - Re: [PATCH] fs/seq_file: Fix warning of passing zero to 'PTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171207232037.GE26792@bombadil.infradead.org>
Date:   Thu, 7 Dec 2017 15:20:37 -0800
From:   Matthew Wilcox <willy@...radead.org>
To:     Vasyl Gomonovych <gomonovych@...il.com>
Cc:     viro@...iv.linux.org.uk, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs/seq_file: Fix warning of passing zero to 'PTR_ERR'

On Fri, Dec 08, 2017 at 12:03:07AM +0100, Vasyl Gomonovych wrote:
> p could be NULL and passing into PTR_ERR

What makes you think this is correct?

To quote the documentation:

The next function to implement is called, amazingly, next(); its job is to
move the iterator forward to the next position in the sequence.  The
example module can simply increment the position by one; more useful
modules will do what is needed to step through some data structure. The
next() function returns a new iterator, or NULL if the sequence is
complete. Here's the example version:

So if it returns NULL, we want to set err to 0 and break.  Which is, um,
exactly what the code does.

Did you test this at all?

> Signed-off-by: Vasyl Gomonovych <gomonovych@...il.com>
> ---
>  fs/seq_file.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/seq_file.c b/fs/seq_file.c
> index 4be761c..8b700b9 100644
> --- a/fs/seq_file.c
> +++ b/fs/seq_file.c
> @@ -262,8 +262,8 @@ ssize_t seq_read(struct file *file, char __user *buf, size_t size, loff_t *ppos)
>  		size_t offs = m->count;
>  		loff_t next = pos;
>  		p = m->op->next(m, p, &next);
> -		if (!p || IS_ERR(p)) {
> -			err = PTR_ERR(p);
> +		if (IS_ERR(p)) {
> +			err = (!p ? -EFAULT : PTR_ERR(p));
>  			break;
>  		}
>  		err = m->op->show(m, p);
> -- 
> 1.9.1
>