linux-kernel - Re: possible deadlock in generic_file_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <740fcf68-091c-707a-2846-df3bf114e608@lge.com>
Date:   Fri, 8 Dec 2017 08:27:15 +0900
From:   Byungchul Park <byungchul.park@....com>
To:     Dmitry Vyukov <dvyukov@...gle.com>
Cc:     Jan Kara <jack@...e.cz>,
        syzbot 
        <bot+045a1f65bdea780940bf0f795a292f4cd0b773d1@...kaller.appspotmail.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Johannes Weiner <hannes@...xchg.org>, jlayton@...hat.com,
        LKML <linux-kernel@...r.kernel.org>,
        Linux-MM <linux-mm@...ck.org>,
        Mel Gorman <mgorman@...hsingularity.net>, npiggin@...il.com,
        rgoldwyn@...e.com, syzkaller-bugs@...glegroups.com,
        Peter Zijlstra <peterz@...radead.org>, kernel-team@....com
Subject: Re: possible deadlock in generic_file_write_iter (2)

On 12/8/2017 2:07 AM, Dmitry Vyukov wrote:
> On Wed, Dec 6, 2017 at 6:05 AM, Byungchul Park <byungchul.park@....com> wrote:
>>>> On 12/4/2017 5:33 PM, Jan Kara wrote:
>>>>>
>>>>> Hello,
>>>>>
>>>>> adding Peter and Byungchul to CC since the lockdep report just looks
>>>>> strange and cross-release seems to be involved. Guys, how did #5 get into
>>>>> the lock chain and what does put_ucounts() have to do with sb_writers
>>>>> there? Thanks!
>>>>
>>>>
>>>> Hello Jan,
>>>>
>>>> In order to get full stack of #5, we have to pass a boot param,
>>>> "crossrelease_fullstack", to the kernel. Now that it only informs
>>>> put_ucounts() in the call trace, it's hard to find out what exactly
>>>> happened at that time, but I can tell #5 shows:
>>>>
>>>> When acquire(sb_writers) in put_ucounts(), it was on the way to
>>>> complete((completion)&req.done) of wait_for_completion() in
>>>> devtmpfs_create_node().
>>>>
>>>> If acquire(sb_writers) in put_ucounts() is stuck, then
>>>> wait_for_completion() in devtmpfs_create_node() would be also
>>>> stuck, since complete() being in the context of acquire(sb_writers)
>>>> cannot be called.
>>>>
>>>> This is why cross-release added the lock chain.
>>>
>>> Hi,
>>>
>>> What is cross-release? Is it something new? Should we always enable
>>> crossrelease_fullstack during testing?
>>
>> Hello Dmitry,
>>
>> Yes, it's new one making lockdep track wait_for_completion() as well.
>>
>> And we should enable crossrelease_fullstack if you don't care system
>> slowdown but testing.
> 
> I've enabled CONFIG_BOOTPARAM_LOCKDEP_CROSSRELEASE_FULLSTACK. It
> should have the same effect, right?

Sure.

-- 
Thanks,
Byungchul