linux-kernel - Re: [PATCH] PM / devfreq: Fix potential NULL pointer dereference in governor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171207175744.Horde.9NnT_zmVm82lkttN8KTbaNG@gator4166.hostgator.com>
Date:   Thu, 07 Dec 2017 17:57:44 -0600
From:   "Gustavo A. R. Silva" <garsilva@...eddedor.com>
To:     MyungJoo Ham <myungjoo.ham@...sung.com>
Cc:     Kyungmin Park <kyungmin.park@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PM / devfreq: Fix potential NULL pointer dereference in
 governor_store


Quoting MyungJoo Ham <myungjoo.ham@...sung.com>:

>> df->governor is being dereferenced before it is null checked,
>> hence there is a potential null pointer dereference.
>>
>> Notice that df->governor is being null checked at line 1004:
>> if (df->governor) {, which implies it might be null.
>>
>> Fix this by null checking df->governor before dereferencing it.
>>
>> Addresses-Coverity-ID: 1401988 ("Dereference before null check")
>> Fixes: bcf23c79c4e4 ("PM / devfreq: Fix available_governor sysfs")
>> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>
>
> Acked-by: MyungJoo Ham <myungjoo.ham@...sung.com>
>

Thank you, MyungJoo

--
Gustavo A. R. Silva