lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAGb2v66esOimRhDHL6QgYU3iWg2a6JiQm__0ivv3SdnQv=SGQg@mail.gmail.com> Date: Thu, 7 Dec 2017 17:14:30 +0800 From: Chen-Yu Tsai <wens@...e.org> To: Quentin Schulz <quentin.schulz@...e-electrons.com> Cc: Chen-Yu Tsai <wens@...e.org>, Maxime Ripard <maxime.ripard@...e-electrons.com>, Sebastian Reichel <sre@...nel.org>, Rob Herring <robh+dt@...nel.org>, Mark Rutland <mark.rutland@....com>, Russell King <linux@...linux.org.uk>, Jonathan Cameron <jic23@...nel.org>, Lee Jones <lee.jones@...aro.org>, Hartmut Knaack <knaack.h@....de>, Lars-Peter Clausen <lars@...afoo.de>, Peter Meerwald-Stadler <pmeerw@...erw.net>, "open list:THERMAL" <linux-pm@...r.kernel.org>, devicetree <devicetree@...r.kernel.org>, linux-kernel <linux-kernel@...r.kernel.org>, linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>, linux-iio@...r.kernel.org, Icenowy Zheng <icenowy@...c.io>, linux-sunxi <linux-sunxi@...glegroups.com>, Thomas Petazzoni <thomas.petazzoni@...e-electrons.com> Subject: Re: [PATCH 3/8] mfd: axp20x: probe axp20x_adc driver for AXP813 On Thu, Dec 7, 2017 at 5:03 PM, Quentin Schulz <quentin.schulz@...e-electrons.com> wrote: > Hi Chen-Yu, > > On 07/12/2017 09:54, Chen-Yu Tsai wrote: >> On Thu, Dec 7, 2017 at 4:51 PM, Quentin Schulz >> <quentin.schulz@...e-electrons.com> wrote: >>> Hi Maxime, >>> >>> On 05/12/2017 09:08, Maxime Ripard wrote: >>>> On Mon, Dec 04, 2017 at 03:12:49PM +0100, Quentin Schulz wrote: >>>>> This makes the axp20x_adc driver probe with platform device id >>>>> "axp813-adc". >>>>> >>>>> Signed-off-by: Quentin Schulz <quentin.schulz@...e-electrons.com> >>>>> --- >>>>> drivers/mfd/axp20x.c | 4 +++- >>>>> 1 file changed, 3 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c >>>>> index 2468b43..42e54d1 100644 >>>>> --- a/drivers/mfd/axp20x.c >>>>> +++ b/drivers/mfd/axp20x.c >>>>> @@ -878,7 +878,9 @@ static struct mfd_cell axp813_cells[] = { >>>>> .resources = axp803_pek_resources, >>>>> }, { >>>>> .name = "axp20x-regulator", >>>>> - } >>>>> + }, { >>>>> + .name = "axp813-adc", >>>>> + }, >>>> >>>> Any particular reason you're not adding it to the DT? >>>> >>> >>> No, no particular reason. It's just the way it is currently for AXP209 >>> and AXP22x so did the same for AXP813. >>> >>> I'll add DT "support" in next version for all AXPs supported by this >>> driver. Or is it worthy of a small separate patch series? >> >> IIRC there's no DT support because there's no need to reference >> it in the device tree. >> > > No current need but that does not mean there won't be a need later for > drivers to map IIO channels from the ADC driver (i.e. some components > wired to GPIOs of the PMIC for example). Hmm... Why would you map the IIO channels from the ADC? I thought those were all accessible from userspace? However, proper muxing of the GPIO pin to the ADC function makes sense. ChenYu
Powered by blists - more mailing lists