linux-kernel - Re: USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1512638231.17062.5.camel@suse.com>
Date:   Thu, 07 Dec 2017 10:17:11 +0100
From:   Oliver Neukum <oneukum@...e.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Dmitry Fleytman <dmitry@...nix.com>,
        Daniel Drake <drake@...lessm.com>,
        Eugene Korenevsky <ekorenevsky@...il.com>,
        Johan Hovold <johan@...nel.org>,
        Mathias Nyman <mathias.nyman@...ux.intel.com>,
        Peter Chen <peter.chen@....com>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Joe Perches <joe@...ches.com>,
        Günter Röck <linux@...ck-us.net>,
        Alan Stern <stern@...land.harvard.edu>,
        SF Markus Elfring <elfring@...rs.sourceforge.net>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        USB list <linux-usb@...r.kernel.org>
Subject: Re: USB: hub: Delete an error message for a failed memory
 allocation in usb_hub_clear_tt_buffer()

Am Donnerstag, den 07.12.2017, 09:56 +0100 schrieb Greg Kroah-Hartman:
> On Thu, Dec 07, 2017 at 09:45:38AM +0100, Geert Uytterhoeven wrote:
> > 
> > A few comments (this is in response to a patch from Markus, so there have
> > to be lots of questions and uncertainties ;-)
> 
> Note, because of the patch author, I'm not applying it no matter what,
> so this discussion is really going nowhere.

We really need to come to a consensus on that question.
If those additional messages really are redundant, we could save
memory deleting them. Or alternatively, if they are not and we need to
know which device is hit, we should centralize that reporting
and tell the VM subsystem not the dump a stack trace.

	Regards
		Oliver