linux-kernel - Re: [PATCH] HID: elecom: rewrite report fixup for EX-G and future mice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.1712071103120.3572@cbobk.fhfr.pm>
Date:   Thu, 7 Dec 2017 11:04:37 +0100 (CET)
From:   Jiri Kosina <jikos@...nel.org>
To:     Tomasz Kramkowski <tk@...-tk.com>
cc:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Yuxuan Shui <yshuiv7@...il.com>,
        Diego Elio Pettenò <flameeyes@...meeyes.eu>,
        Alex Manoussakis <amanou@....org>, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: elecom: rewrite report fixup for EX-G and future
 mice

On Tue, 5 Dec 2017, Tomasz Kramkowski wrote:

> On Mon, Dec 04, 2017 at 08:55:50PM +0000, Tomasz Kramkowski wrote:
> > +static void mouse_button_fixup(struct hid_device *hdev,
> > +			       __u8 *rdesc, unsigned int *rsize,
> > +			       int nbuttons)
> 
> I've just remembered what has been bugging me yesterday when I was
> reviewing this patch. I had come to the realisation (and then
> subsequently forgotten) that this function should probably return __u8 *
> and also get assigned to rdesc on the other end. It seems to me that it
> makes most sense to allow for the possibility (although slim) of this
> function eventually being expanded to actually replace the report
> descriptor 

Sure, but you can extend the API of mouse_button_fixup() once such need 
arises; no need to pass data pointers around without having actual use for 
them.

-- 
Jiri Kosina
SUSE Labs