linux-kernel - Re: [PATCH v2 02/15] soc: qcom: add support to APR bus driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c6723fbe-1c15-80a6-b40d-09eb80882795@linaro.org>
Date:   Thu, 7 Dec 2017 10:33:25 +0000
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Philippe Ombredanne <pombredanne@...b.com>
Cc:     Mark <broonie@...nel.org>, bgoswami@...eaurora.org,
        ALSA <alsa-devel@...a-project.org>, tiwai@...e.com,
        plai@...eaurora.org, kwestfie@...eaurora.org,
        LKML <linux-kernel@...r.kernel.org>,
        linux-arm-msm@...r.kernel.org, lkasam@....qualcomm.com
Subject: Re: [PATCH v2 02/15] soc: qcom: add support to APR bus driver



On 07/12/17 09:53, Philippe Ombredanne wrote:
> Srinivas,
> 
> On Tue, Dec 5, 2017 at 11:17 PM,  <srinivas.kandagatla@...aro.org> wrote:
>> From: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
>>
>> This patch adds support toi APR bus (Asynchronous Packet Router) driver.
>> ARP driver is made as a bus driver so that the apr devices can added removed
>> more dynamically depending on the state of the services on the dsp.
>> APR is used for communication between application processor and QDSP to
>> use services on QDSP like Audio and others.
>>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> []
>> --- /dev/null
>> +++ b/drivers/soc/qcom/apr.c
>> @@ -0,0 +1,395 @@
>> +/* SPDX-License-Identifier: GPL-2.0
>> +* Copyright (c) 2011-2016, The Linux Foundation
>> +* Copyright (c) 2017, Linaro Limited
>> +*/
> 
> Accept my apologies as I am nitpicking there, but I think that Linus's
> preferred style for the SPDX id line is the C++  style //.
> 
Thanks for review, I just realized this, I will fix this in next version.


> And while you are at it since these is only license and copyrights you
> could go with this all the way, as in this:
> 
>> +// SPDX-License-Identifier: GPL-2.0
>> +// Copyright (c) 2011-2016, The Linux Foundation
>> +// Copyright (c) 2017, Linaro Limited
Yep, thanks,

srini
> 
> You can check the doc patches posted by Thomas (tglx) and earlier
> comments from Linus wrt comment style and his good rationale for
> these.
>