lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Thu, 7 Dec 2017 05:17:37 -0600 (CST)
From:   Christopher Lameter <cl@...ux.com>
To:     Geert Uytterhoeven <geert+renesas@...der.be>
cc:     Pekka Enberg <penberg@...nel.org>,
        David Rientjes <rientjes@...gle.com>,
        Joonsoo Kim <iamjoonsoo.kim@....com>,
        Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/slab: Merge adjacent debug sections

On Thu, 7 Dec 2017, Geert Uytterhoeven wrote:

> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -1569,9 +1569,6 @@ static void dump_line(char *data, int offset, int limit)
>  		}
>  	}
>  }
> -#endif
> -
> -#if DEBUG


Hmmm... This may match at other places. Also there are a lot of #ifdef
DEBUG / #else in that section of the code. Maybe better leave as is? Or
generally rework this into a single #ifdef DEBUG section with all the
debugging code in it and an #else section with all the empty functions.


Powered by blists - more mailing lists