linux-kernel - [RESEND][PATCH 1/3] lustre: don't set f_version in ll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171207113206.31544-2-jlayton@kernel.org>
Date:   Thu,  7 Dec 2017 06:32:04 -0500
From:   Jeff Layton <jlayton@...nel.org>
To:     akpm@...ux-foundation.org
Cc:     lustre-devel@...ts.lustre.org, anton@...era.com,
        andreas.dilger@...el.com, oleg.drokin@...el.com,
        jsimmons@...radead.org, mikulas@...ax.karlin.mff.cuni.cz,
        linux-kernel@...r.kernel.org, linux-ntfs-dev@...ts.sourceforge.net,
        linux-fsdevel@...r.kernel.org
Subject: [RESEND][PATCH 1/3] lustre: don't set f_version in ll_readdir

From: Jeff Layton <jlayton@...hat.com>

f_version is only ever used by filesystem-specific code. Generic
VFS code never uses it.

Nothing in lustre ever looks at it, so just remove this.

Signed-off-by: Jeff Layton <jlayton@...hat.com>
Reviewed-by: Andreas Dilger <andreas.dilger@...el.com>
---
 drivers/staging/lustre/lustre/llite/dir.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/staging/lustre/lustre/llite/dir.c b/drivers/staging/lustre/lustre/llite/dir.c
index 5b2e47c246f3..6f59045be0f9 100644
--- a/drivers/staging/lustre/lustre/llite/dir.c
+++ b/drivers/staging/lustre/lustre/llite/dir.c
@@ -369,8 +369,6 @@ static int ll_readdir(struct file *filp, struct dir_context *ctx)
 	}
 	ctx->pos = pos;
 	ll_finish_md_op_data(op_data);
-	filp->f_version = inode->i_version;
-
 out:
 	if (!rc)
 		ll_stats_ops_tally(sbi, LPROC_LL_READDIR, 1);
@@ -1678,7 +1676,6 @@ static loff_t ll_dir_seek(struct file *file, loff_t offset, int origin)
 			else
 				fd->lfd_pos = offset;
 			file->f_pos = offset;
-			file->f_version = 0;
 		}
 		ret = offset;
 	}
-- 
2.14.3