linux-kernel - Re: [PATCH] integrity: get rid of unneeded initializations in integrity_iint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1512648098.1350.6.camel@kernel.org>
Date:   Thu, 07 Dec 2017 07:01:38 -0500
From:   Jeff Layton <jlayton@...nel.org>
To:     Mimi Zohar <zohar@...ux.vnet.ibm.com>,
        "Serge E. Hallyn" <serge@...lyn.com>
Cc:     linux-kernel@...r.kernel.org, linux-security-module@...r.kernel.org
Subject: Re: [PATCH] integrity: get rid of unneeded initializations in
 integrity_iint_cache entries

On Thu, 2017-07-06 at 15:43 -0400, Mimi Zohar wrote:
> On Thu, 2017-07-06 at 10:04 -0500, Serge E. Hallyn wrote:
> > Quoting Jeff Layton (jlayton@...nel.org):
> > > From: Jeff Layton <jlayton@...hat.com>
> > > 
> > > The init_once routine memsets the whole object to 0, and then
> > > explicitly sets some of the fields to 0 again. Just remove the explicit
> > > initializations.
> > > 
> > > Signed-off-by: Jeff Layton <jlayton@...hat.com>
> > 
> > Reviewed-by: Serge Hallyn <serge@...lyn.com>
> 
> Thanks, queued.
> 
> Mimi
> 

Hi Mimi,

I notice that this patch hasn't made the last couple of releases. Was it
dropped for some reason?

Thanks,
Jeff

> > 
> > > ---
> > >  security/integrity/iint.c | 3 ---
> > >  1 file changed, 3 deletions(-)
> > > 
> > > diff --git a/security/integrity/iint.c b/security/integrity/iint.c
> > > index 6fc888ca468e..187b7cb378be 100644
> > > --- a/security/integrity/iint.c
> > > +++ b/security/integrity/iint.c
> > > @@ -153,14 +153,11 @@ static void init_once(void *foo)
> > >  	struct integrity_iint_cache *iint = foo;
> > >  
> > >  	memset(iint, 0, sizeof(*iint));
> > > -	iint->version = 0;
> > > -	iint->flags = 0UL;
> > >  	iint->ima_file_status = INTEGRITY_UNKNOWN;
> > >  	iint->ima_mmap_status = INTEGRITY_UNKNOWN;
> > >  	iint->ima_bprm_status = INTEGRITY_UNKNOWN;
> > >  	iint->ima_read_status = INTEGRITY_UNKNOWN;
> > >  	iint->evm_status = INTEGRITY_UNKNOWN;
> > > -	iint->measured_pcrs = 0;
> > >  }
> > >  
> > >  static int __init integrity_iintcache_init(void)
> > > -- 
> > > 2.13.0
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
> > the body of a message to majordomo@...r.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > 
> 
> 

-- 
Jeff Layton <jlayton@...nel.org>