linux-kernel - Re: [PATCH 09/45] drivers: media: remove duplicate includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171207133522.yqgb532ftcgvw62d@valkosipuli.retiisi.org.uk>
Date:   Thu, 7 Dec 2017 15:35:22 +0200
From:   Sakari Ailus <sakari.ailus@....fi>
To:     Pravin Shedge <pravin.shedge4linux@...il.com>
Cc:     linux-media@...r.kernel.org, mchehab@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 09/45] drivers: media: remove duplicate includes

Hi Pravin,

On Wed, Dec 06, 2017 at 10:22:02PM +0530, Pravin Shedge wrote:
> These duplicate includes have been found with scripts/checkincludes.pl but
> they have been removed manually to avoid removing false positives.
> 
> Signed-off-by: Pravin Shedge <pravin.shedge4linux@...il.com>

While at it, how about ordering the headers alphabetically as well? Having
such a large number of headers there unordered may well be the reason why
they're included more than once...

-- 
Sakari Ailus
e-mail: sakari.ailus@....fi