linux-kernel - Re: [PATCH] Makefile: .PHONY is not a variable, but PHONY is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNAQKve7Uha3_3hMNiMP8VMyJz9A7iXKj06MJWC8dxXvkQw@mail.gmail.com>
Date:   Fri, 8 Dec 2017 00:03:33 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     ulfalizer.lkml@...il.com, Ulf Magnusson <ulfalizer@...il.com>
Cc:     Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Jiri Kosina <trivial@...nel.org>
Subject: Re: [PATCH] Makefile: .PHONY is not a variable, but PHONY is

Hi Ulf,




2015-09-02 22:11 GMT+09:00  <ulfalizer.lkml@...il.com>:
> From: Ulf Magnusson <ulfalizer@...il.com>
>
> .PHONY is a target, not a variable.
>
> Signed-off-by: Ulf Magnusson <ulfalizer@...il.com>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 24c9e3d..4835d24 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1609,6 +1609,6 @@ endif     # skip-makefile
>  PHONY += FORCE
>  FORCE:
>
> -# Declare the contents of the .PHONY variable as phony.  We keep that
> +# Declare the contents of the PHONY variable as phony.  We keep that
>  # information in a variable so we can use it in if_changed and friends.
>  .PHONY: $(PHONY)
> --


I found this patch by chance.


Can you fix other files in scripts/ as well?

I see the same pattern in

Makefile.build
Makefile.clean
Makefile.modbuiltin
Makefile.modinst
Makefile.modpost
Makefile.modsign

Then, I will apply it quickly.



-- 
Best Regards
Masahiro Yamada