linux-kernel - RE: [PATCH] PM / devfreq: Fix potential NULL pointer dereference in governor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171207024144epcms1p4d7e1a981c7c307190a85e8c35174d983@epcms1p4>
Date:   Thu, 07 Dec 2017 02:41:44 +0000
From:   MyungJoo Ham <myungjoo.ham@...sung.com>
To:     Kyungmin Park <kyungmin.park@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>
CC:     "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Gustavo A. R. Silva" <garsilva@...eddedor.com>
Subject: RE: [PATCH] PM / devfreq: Fix potential NULL pointer dereference in
 governor_store

> df->governor is being dereferenced before it is null checked,
> hence there is a potential null pointer dereference.
> 
> Notice that df->governor is being null checked at line 1004:
> if (df->governor) {, which implies it might be null.
> 
> Fix this by null checking df->governor before dereferencing it.
> 
> Addresses-Coverity-ID: 1401988 ("Dereference before null check")
> Fixes: bcf23c79c4e4 ("PM / devfreq: Fix available_governor sysfs")
> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>

Acked-by: MyungJoo Ham <myungjoo.ham@...sung.com>


Cheers,
MyungJoo

> ---
>  drivers/devfreq/devfreq.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 78fb496..14fe76b 100644