linux-kernel - Re: [PATCH] tools/slabinfo-gnuplot: force to use bash shell

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1512771659.1845.40.camel@perches.com>
Date:   Fri, 08 Dec 2017 14:20:59 -0800
From:   Joe Perches <joe@...ches.com>
To:     Andrew Morton <akpm@...ux-foundation.org>,
        Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
Cc:     "Liu, Changcheng" <changcheng.liu@...el.com>,
        sergey.senozhatsky@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tools/slabinfo-gnuplot: force to use bash shell

On Fri, 2017-12-08 at 14:02 -0800, Andrew Morton wrote:
> On Fri, 8 Dec 2017 19:33:15 +0900 Sergey Senozhatsky <sergey.senozhatsky.work@...il.com> wrote:
> 
> > On (12/08/17 17:37), Liu, Changcheng wrote:
> > > 
> > > On some linux distributions, the default link of sh
> > > is dash which deoesn't support split array like
> > > ${var//,/ }
> > > It's better to force to use bash shell directly.
> > > 
> > > Signed-off-by: Liu Changcheng <changcheng.liu@...el.com>
> > 
> > Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> 
> It would be better to rewrite the script to avoid bashisms.  But...
> 
> akpm3:/usr/src/linux-4.15-rc2> grep -rl "/bin/bash" . | wc -l
> 164
> 
> I guess we lost that fight a long time ago.

103 of those are in tools/ and I don't think those count.
If you take out samples/ and Documentation/ it's down to 24.