linux-kernel - Re: [PATCH 4.4 38/49] xen-netfront: Improve error handling during initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1512709849.18523.245.camel@codethink.co.uk>
Date:   Fri, 08 Dec 2017 05:10:49 +0000
From:   Ben Hutchings <ben.hutchings@...ethink.co.uk>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Cc:     stable@...r.kernel.org, Ross Lagerwall <ross.lagerwall@...rix.com>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        "David S. Miller" <davem@...emloft.net>,
        Sasha Levin <alexander.levin@...izon.com>
Subject: Re: [PATCH 4.4 38/49] xen-netfront: Improve error handling during
 initialization

On Thu, 2017-12-07 at 14:07 +0100, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.  If anyone has any objections, please let me
> know.
> 
> ------------------
> 
> From: Ross Lagerwall <ross.lagerwall@...rix.com>
> 
> 
> [ Upstream commit e2e004acc7cbe3c531e752a270a74e95cde3ea48 ]
[...]
> @@ -1950,9 +1942,10 @@ abort_transaction_no_dev_fatal:
>  	xenbus_transaction_end(xbt, 1);
>   destroy_ring:
>  	xennet_disconnect_backend(info);
> -	kfree(info->queues);
> -	info->queues = NULL;
> +	xennet_destroy_queues(info);
>   out:
> +	unregister_netdev(info->netdev);
> +	xennet_free_netdev(info->netdev);
>  	return err;
>  }

This last bit of cleanup looks wrong.  It was subsequently changed
upstream by:

86b5672b1adb xen-netfront: avoid crashing on resume after a failure in talk_to_netback()

Ben.

-- 
Ben Hutchings
Software Developer, Codethink Ltd.