linux-kernel - Re: [f2fs-dev] [PATCH] f2fs: release reserved blocks for quota

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171208052412.GA77074@jaegeuk-macbookpro.roam.corp.google.com>
Date:   Thu, 7 Dec 2017 21:24:12 -0800
From:   Jaegeuk Kim <jaegeuk@...nel.org>
To:     LiFan <fanofcode.li@...sung.com>
Cc:     'Chao Yu' <yuchao0@...wei.com>, 'Chao Yu' <chao@...nel.org>,
        linux-kernel@...r.kernel.org,
        linux-f2fs-devel@...ts.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: release reserved blocks for quota

On 12/05, LiFan wrote:
> 
> Quota has been modified during inc_valid_block_count(), but not in
> truncate process. This patch adds it.
> 
> Signed-off-by: Fan li <fanofcode.li@...sung.com>
> ---
>  fs/f2fs/f2fs.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> index 82f1dc3..71fbba96 100644
> --- a/fs/f2fs/f2fs.h
> +++ b/fs/f2fs/f2fs.h
> @@ -1619,7 +1619,9 @@ static inline void dec_valid_block_count(struct f2fs_sb_info *sbi,
>  		sbi->current_reserved_blocks = min(sbi->reserved_blocks,
>  					sbi->current_reserved_blocks + count);
>  	spin_unlock(&sbi->stat_lock);
> +
>  	f2fs_i_blocks_write(inode, count, false, true);
> +	dquot_release_reservation_block(inode, count);

The f2fs_i_blocks_write() actually handles allocation, and reserved blocks are
only used for inc_valid_block_count().

Thanks,

>  }
>  
>  static inline void inc_page_count(struct f2fs_sb_info *sbi, int count_type)
> -- 
> 2.7.4
>