linux-kernel - Re: [PATCH net-next V2] tuntap: fix possible deadlock when fail to register netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1512711366.25033.21.camel@gmail.com>
Date:   Thu, 07 Dec 2017 21:36:06 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Jason Wang <jasowang@...hat.com>, netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, mst@...hat.com,
        Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net-next V2] tuntap: fix possible deadlock when fail to
 register netdev

On Fri, 2017-12-08 at 12:02 +0800, Jason Wang wrote:
> Private destructor could be called when register_netdev() fail with
> rtnl lock held. This will lead deadlock in tun_free_netdev() who
> tries
> to hold rtnl_lock. Fixing this by switching to use spinlock to
> synchronize.
> 
> Fixes: 96f84061620c ("tun: add eBPF based queue selection method")
> Reported-by: Eric Dumazet <eric.dumazet@...il.com>
> Cc: Eric Dumazet <eric.dumazet@...il.com>
> Cc: Willem de Bruijn <willemb@...gle.com>
> Signed-off-by: Jason Wang <jasowang@...hat.com>
> ---

Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Thanks.